-
-
Notifications
You must be signed in to change notification settings - Fork 137
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
apply go fmt with Go 1.21 #394
Conversation
Codecov Report
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #394 +/- ##
=======================================
Coverage 76.02% 76.02%
=======================================
Files 13 13
Lines 4692 4692
=======================================
Hits 3567 3567
Misses 866 866
Partials 259 259 |
If we use Go 1.21 based gofmt, I think that the go.mod version needs to be 1.21, not 1.19. |
With Go 1.19.13, I got same result.
|
I see. I also tried gofmt with go1.19 and got the same result. So it wasn't a change from 1.21. LGTM 👍 |
[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [github.com/goccy/go-yaml](https://togithub.com/goccy/go-yaml) | require | patch | `v1.11.1` -> `v1.11.2` | --- ### Release Notes <details> <summary>goccy/go-yaml (github.com/goccy/go-yaml)</summary> ### [`v1.11.2`](https://togithub.com/goccy/go-yaml/releases/tag/v1.11.2): 1.11.2 [Compare Source](https://togithub.com/goccy/go-yaml/compare/v1.11.1...v1.11.2) #### What's Changed - Fix handle of space at start or last by [@​ozraru](https://togithub.com/ozraru) in [https://github.com/goccy/go-yaml/pull/376](https://togithub.com/goccy/go-yaml/pull/376) - Fix quoted comments by [@​WillAbides](https://togithub.com/WillAbides) in [https://github.com/goccy/go-yaml/pull/370](https://togithub.com/goccy/go-yaml/pull/370) - Fix sequence with comment by [@​goccy](https://togithub.com/goccy) in [https://github.com/goccy/go-yaml/pull/390](https://togithub.com/goccy/go-yaml/pull/390) - bump actions/checkout v4 by [@​shogo82148](https://togithub.com/shogo82148) in [https://github.com/goccy/go-yaml/pull/391](https://togithub.com/goccy/go-yaml/pull/391) - add Go 1.21 to the build matrix by [@​shogo82148](https://togithub.com/shogo82148) in [https://github.com/goccy/go-yaml/pull/392](https://togithub.com/goccy/go-yaml/pull/392) - apply go fmt with Go 1.21 by [@​shogo82148](https://togithub.com/shogo82148) in [https://github.com/goccy/go-yaml/pull/394](https://togithub.com/goccy/go-yaml/pull/394) - bump actions/setup-go v4 by [@​shogo82148](https://togithub.com/shogo82148) in [https://github.com/goccy/go-yaml/pull/393](https://togithub.com/goccy/go-yaml/pull/393) #### New Contributors - [@​WillAbides](https://togithub.com/WillAbides) made their first contribution in [https://github.com/goccy/go-yaml/pull/370](https://togithub.com/goccy/go-yaml/pull/370) - [@​shogo82148](https://togithub.com/shogo82148) made their first contribution in [https://github.com/goccy/go-yaml/pull/391](https://togithub.com/goccy/go-yaml/pull/391) **Full Changelog**: goccy/go-yaml@v1.11.1...v1.11.2 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/anoriqq/qpm). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNi44My4wIiwidXBkYXRlZEluVmVyIjoiMzYuODMuMCIsInRhcmdldEJyYW5jaCI6Im1haW4ifQ==--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
go fmt now formats godoc comments.